cmplr.env: err_pattern fix for scrip_errormod false positive #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
During building, in addition to error messages, remarks and warning outputs, along with the file name, can appear in the files'
.err
output. In the case ofscrip_errormod.f90
, this can lead to termination of the build due tocomp
grep
ing for the word 'error', and finding it as a substring of the file name.Description
This PR addresses a potential bug in the build scripts where
.err
files aregrep
ed for the word 'error'. If the name of the file contains the word error, it could unnecessarily trigger a compile to abort based only on finding it as a substring in the name. I used potential because this error was discovered while using non-WW3 (UFS) debug flags to compile, though that does not mean it can't occur otherwise. This fix works by adding to theerr_pattern
the requirement of whitespace (space, tab, newline, carriage return) on either side of the word error. This means that the use of error in a variable name, file name, etc. will not be flagged as a problem bycomp
. This is not expected to change answers.Please also include the following information:
Issue(s) addressed
Commit Message
scrip_errormod.f90: fixes build failure due to 'error' substring in file name
Check list
Testing
How were these changes tested?
intel_debug
). Then runningmatrix.comp
the only differences were those of the known issues.Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the matrix regression tests been run (if yes, please note HPC and compiler)?
hera.intel
.Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
matrixCompSummary.txt
matrixCompFull.txt
matrixDiff.txt
Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).